Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/prometheus sanitization #3470

Merged

Conversation

samimusallam
Copy link
Member

@samimusallam samimusallam commented Dec 6, 2022

Fixes #3464

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been updated

@samimusallam samimusallam requested a review from a team December 6, 2022 13:56
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #3470 (0f6ec6a) into main (e70cdeb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3470   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files         248      248           
  Lines        7566     7567    +1     
  Branches     1580     1580           
=======================================
+ Hits         7095     7096    +1     
  Misses        471      471           
Impacted Files Coverage Δ
...ry-exporter-prometheus/src/PrometheusSerializer.ts 95.71% <100.00%> (+0.03%) ⬆️

@legendecas legendecas merged commit e3a81d2 into open-telemetry:main Dec 8, 2022
@samimusallam samimusallam deleted the fix/prometheus-sanitization branch December 22, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus exporter: replace repeated _ with a single _
5 participants